make PropertyValueList dynamically add and remove values

2024-07-25 16:57:51 +02:00
parent 446b205a79
commit 9b14ba2a3a
4 changed files with 22 additions and 7 deletions
@@ -2533,17 +2533,24 @@
    return viewBuilder(matchingObjects);
  }

-  // src/View/Components/propertyList.tsx
+  // src/View/Components/propertyValueList.tsx
  function PropertyValueList(propertyKey, stringEntryObjectConverter, objects, viewBuilder) {
    const propertyValues = new ListState();
    function collectValues() {
-      propertyValues.clear();
      const values = collectObjectValuesForKey(
        propertyKey,
        stringEntryObjectConverter,
        [...objects.value.values()]
      );
-      propertyValues.add(...values);
+      for (const existingValue of values) {
+        if (propertyValues.value.has(existingValue)) continue;
+        propertyValues.add(existingValue);
+      }
+      for (const displayedValue of propertyValues.value.values()) {
+        if (values.includes(displayedValue) == false) {
+          propertyValues.remove(displayedValue);
+        }
+      }
    }
    objects.subscribe(() => {
      collectValues();